----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30014/#review73715 -----------------------------------------------------------
src/slave/slave.cpp <https://reviews.apache.org/r/30014/#comment120100> I don't think this is the right approach, as you're re-ordering garbage collections by changing the delay here. Rather, you want to "speed up" garbage collection when we're approaching the limit on the number of links (see Slave::checkDiskUsage for where we periodically speed up garbage collection based on the disk usage). - Ben Mahler On Jan. 22, 2015, 9:35 p.m., Ritwik Yadav wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30014/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2015, 9:35 p.m.) > > > Review request for mesos, Ben Mahler, Dominic Hamon, and Vinod Kone. > > > Bugs: MESOS-391 > https://issues.apache.org/jira/browse/MESOS-391 > > > Repository: mesos > > > Description > ------- > > A fix to enable the slave garbage collector to take the number of hard links > (st_nlinks) into account when creating new directories. > > [UPDATE] - Distributed the changes into two review requests as per > information posted by the Mesos ReviewBot. > > > Diffs > ----- > > src/slave/constants.hpp 761cfafb3b1b342af4d1dbdb2dec39a45dd62794 > src/slave/constants.cpp 83d9fc1cd385722deb31883c17c824fd0e1de8a6 > src/slave/flags.hpp 33a0cb639cd85ce4e03bd4ceaa3fed0834c239b9 > src/slave/slave.cpp fca83b3977b95ddda30f9830da10e124b5c605e6 > > Diff: https://reviews.apache.org/r/30014/diff/ > > > Testing > ------- > > Mesos builds sucessfully and all existing tests pass. > > > Thanks, > > Ritwik Yadav > >
