-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30014/
-----------------------------------------------------------

(Updated Feb. 27, 2015, 6:44 p.m.)


Review request for mesos, Ben Mahler, Dominic Hamon, and Vinod Kone.


Changes
-------

I have updated the diff as I had described in my previous message. Instead of 
changing the order of garbage collection, I modified the code to make age a 
function of disk usage as well as the number of links (executor directories) 
used up by the frameworks registered with the corresponding slave. 

I did this to quickly demonstrate the changes. I still need to add more 
explanatory comments once I know I am on the right track now. Thanks for all 
the help and bearing with me.


Bugs: MESOS-391
    https://issues.apache.org/jira/browse/MESOS-391


Repository: mesos


Description (updated)
-------

A fix to enable the slave garbage collector to take the number of hard links 
(st_nlinks) into account when creating new directories.


Diffs (updated)
-----

  src/slave/constants.hpp fd1c1aba0aa62372ab399bee5709ce81b8e92cec 
  src/slave/constants.cpp 2a99b1105af0e2d62b956fa96988f477937a46bd 
  src/slave/flags.hpp 56b25caf3901b38bdecb50310e8bcae0b114efa8 
  src/slave/paths.hpp 1618439d728ded347ec75317ce8dd998acd7ee94 
  src/slave/paths.cpp 01ea856aa2e628d4aee5fd31f7e49d147f740e8f 
  src/slave/slave.hpp 7b58cade9ada5f0a56b4c60c502eb907ccae33b4 
  src/slave/slave.cpp 9f31fa46304398e8f87b41b55d8f4cfd4aba10b9 

Diff: https://reviews.apache.org/r/30014/diff/


Testing
-------

Mesos builds sucessfully and all existing tests pass.


Thanks,

Ritwik Yadav

Reply via email to