----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28141/#review73855 -----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.cpp <https://reviews.apache.org/r/28141/#comment120265> This looks buggy to me. `isolator->prepare()` might be called already. Looking at our isolators, looks like we usually create an Info struct when `prepare` is called and delete the Info struct in `cleanup`. The shortcut here could cause a leak of this data structure. This is problematic because the port mapping isolator will run out of ephemeral ports because of this. BTW, I don't see any comments in the public header of isolator.hpp saying that prepare does not need any cleanup. - Jie Yu On Nov. 21, 2014, 11:20 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28141/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2014, 11:20 p.m.) > > > Review request for mesos and Ian Downes. > > > Bugs: MESOS-1922 > https://issues.apache.org/jira/browse/MESOS-1922 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp > 3baea316f345aaa4abd1e16ca4ac308f0a308502 > src/slave/containerizer/mesos/containerizer.cpp > 24f90b663813e5919b9eb9e64aee006d6d0a612e > src/tests/containerizer_tests.cpp a63897b5ae01a70689714aeb0d6e33bed8b3b263 > > Diff: https://reviews.apache.org/r/28141/diff/ > > > Testing > ------- > > Make check. > > > Thanks, > > Timothy Chen > >
