> On Feb. 24, 2015, 6:52 p.m., Ian Downes wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 898-907 > > <https://reviews.apache.org/r/28141/diff/3/?file=772869#file772869line898> > > > > Yeah, I agree. This would leave the isolators to continue preparing and > > cleanup would never be called. It also won't explicitly kill the forked > > executor-to-be. > > > > If the container is in PREPARING we should ideally cancel the prepare() > > futures or wait until they're complete and then call cleanup() on each > > isolator, i.e., the normal destroy path. > > > > Tim, can you take look a this. > > Jie Yu wrote: > Thanks for confirming, Ian! I've created a ticket to track: > https://issues.apache.org/jira/browse/MESOS-2398 > > Timothy Chen wrote: > Thanks Jie for looking into this again, I believe I asked Ian at the time > if it's safe to do this, but it's a bit blurry now and I can't remember the > exact details. > Regardless, if what you're saying is true we definitely should fix this. > I'll come up with a fix for this.
Thanks Tim! - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28141/#review73857 ----------------------------------------------------------- On Nov. 21, 2014, 11:20 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28141/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2014, 11:20 p.m.) > > > Review request for mesos and Ian Downes. > > > Bugs: MESOS-1922 > https://issues.apache.org/jira/browse/MESOS-1922 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp > 3baea316f345aaa4abd1e16ca4ac308f0a308502 > src/slave/containerizer/mesos/containerizer.cpp > 24f90b663813e5919b9eb9e64aee006d6d0a612e > src/tests/containerizer_tests.cpp a63897b5ae01a70689714aeb0d6e33bed8b3b263 > > Diff: https://reviews.apache.org/r/28141/diff/ > > > Testing > ------- > > Make check. > > > Thanks, > > Timothy Chen > >
