> On Feb. 25, 2015, 6:43 p.m., Ben Mahler wrote: > > include/mesos/resources.hpp, lines 107-108 > > <https://reviews.apache.org/r/30850/diff/3/?file=875892#file875892line107> > > > > Checkpointing seems like a mesos implementation detail, any reason you > > want it in resources.hpp? What about creating a resource_utils.hpp or > > moving it to protobuf_utils.hpp with a TODO?
Moved to resources_utils.hpp. > On Feb. 25, 2015, 6:43 p.m., Ben Mahler wrote: > > include/mesos/resources.hpp, lines 304-312 > > <https://reviews.apache.org/r/30850/diff/3/?file=875892#file875892line304> > > > > Ditto here, let's try not to leak mesos implementation into > > resources.hpp. Can you move this out for now (maybe protobuf_utils.hpp as a > > placeholder?). Moved to resources_utils.hpp > On Feb. 25, 2015, 6:43 p.m., Ben Mahler wrote: > > src/slave/slave.cpp, lines 3643-3644 > > <https://reviews.apache.org/r/30850/diff/3/?file=875896#file875896line3643> > > > > Can you comment on the None() case here? Is it when we simply don't > > have any checkpointed resources? Added a note here and a TODO in state::recover(). > On Feb. 25, 2015, 6:43 p.m., Ben Mahler wrote: > > src/slave/slave.cpp, line 3655 > > <https://reviews.apache.org/r/30850/diff/3/?file=875896#file875896line3655> > > > > Could we call this something like `applyCheckpointedResources`? Renamed. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30850/#review74044 ----------------------------------------------------------- On Feb. 25, 2015, 5:53 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30850/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2015, 5:53 p.m.) > > > Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Added validation for checkpointed resources during slave recovery. > > This is a rebased version for https://reviews.apache.org/r/29913/ > > > Diffs > ----- > > include/mesos/resources.hpp da6d48871a0061d8bbf5e681dd6e7edac659d812 > src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059 > src/master/master.hpp d414061b1aa7b4cac6ab9a3cc14e8e028f9370d0 > src/slave/slave.hpp f3eab7ed7f9b098e46405464f922c7f2165822b4 > src/slave/slave.cpp e52ff5a1feb9006bfa8b6dfa6266126114dfbdff > src/tests/mesos.hpp 6b9656b2b858df75e725aaa042c447b755899c87 > src/tests/mesos.cpp df051d9f647ed716f06055c312f18d8d1759a437 > src/tests/persistent_volume_tests.cpp > 2b67370c34d521d157f2f22c2de9f684a0b5446c > > Diff: https://reviews.apache.org/r/30850/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
