> On Feb. 12, 2015, 10:14 a.m., Michael Park wrote: > > src/slave/slave.cpp, lines 3520-3551 > > <https://reviews.apache.org/r/30850/diff/2/?file=860896#file860896line3520> > > > > We have pretty much the same code in `master.hpp:766-785` with > > `totalResources` and `checkpointedResources` involved. Could we consolidate > > them into a function that returns the inferred `totalResources` in a > > `Try<Resources>`? > > > > For `checkpointedResources`, we simply do `checkpointedResources = > > resourcesState.get().resources;` here. In `master.hpp` it's seems to be a > > similar situation where instead of `resourcesState.get().resources` we're > > have a `_checkpointedResources` that we should be able to just assign.
Jie, do you wnat to put a common implementation in resources.hpp for now? - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30850/#review72127 ----------------------------------------------------------- On Feb. 11, 2015, 6:38 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30850/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2015, 6:38 p.m.) > > > Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Added validation for checkpointed resources during slave recovery. > > This is a rebased version for https://reviews.apache.org/r/29913/ > > > Diffs > ----- > > src/slave/slave.hpp 7a399f6df50c69b7e1e12d74f076fa57b6edb1b3 > src/slave/slave.cpp f39a876cdd6b580a7a75fd053e6923761bee7635 > src/tests/mesos.hpp 2b0c90d166ed33065f2a4a2909c61cc5119da511 > src/tests/mesos.cpp ac2dc737eff48d122cfd604d4820f423e5bc0472 > src/tests/persistent_volume_tests.cpp > b4f2298069233b27f6b4b8d668753810f43bb58d > > Diff: https://reviews.apache.org/r/30850/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
