> On Feb. 19, 2015, 3:56 a.m., Michael Park wrote: > > src/examples/test_hook_module.cpp, lines 35-36 > > <https://reviews.apache.org/r/30961/diff/3/?file=863922#file863922line35> > > > > Could you help me understand why this is necessary?
We do string comparisons on both sides of the library border. It was introduced with the hooks test, but we should probably move to a common header. Can add a JIRA/TODO. - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30961/#review73124 ----------------------------------------------------------- On Feb. 26, 2015, 5:55 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30961/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2015, 5:55 p.m.) > > > Review request for mesos, Ben Mahler and Kapil Arya. > > > Bugs: MESOS-2351 > https://issues.apache.org/jira/browse/MESOS-2351 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/hook.hpp d83ace576a2c78eb7b1e910d89d912f6df5c46ef > src/examples/test_hook_module.cpp 8faf6850aafcebda7e9f0d1b735d61f7effa842d > src/hook/manager.cpp 3fd9d5e7f81e3d0ca2aca4091beba4ae555ae7e7 > src/master/master.cpp 76e217d16c03e587ea4c0afca94c58b2212f0f93 > src/tests/hook_tests.cpp f4b4f519456dc00a8894c7ce154b28a7ab9ce493 > > Diff: https://reviews.apache.org/r/30961/diff/ > > > Testing > ------- > > make check (with modified VerifyMasterLaunchTaskHook test) > > > Thanks, > > Niklas Nielsen > >
