> On Feb. 19, 2015, 4:22 a.m., Michael Park wrote: > > src/tests/hook_tests.cpp, lines 178-186 > > <https://reviews.apache.org/r/30961/diff/3/?file=863925#file863925line178> > > > > Seems like we could simplify this to something like: > > > > ```cpp > > const Labels &labels = taskInfo.get().labels(); > > ASSERT_EQ(1, labels.labels_size()); > > > > EXPECT_EQ(labels.labels().Get(0).key(), testLabelKey); > > ```
Excellent suggestion! Thanks - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30961/#review73129 ----------------------------------------------------------- On Feb. 26, 2015, 5:55 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30961/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2015, 5:55 p.m.) > > > Review request for mesos, Ben Mahler and Kapil Arya. > > > Bugs: MESOS-2351 > https://issues.apache.org/jira/browse/MESOS-2351 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/hook.hpp d83ace576a2c78eb7b1e910d89d912f6df5c46ef > src/examples/test_hook_module.cpp 8faf6850aafcebda7e9f0d1b735d61f7effa842d > src/hook/manager.cpp 3fd9d5e7f81e3d0ca2aca4091beba4ae555ae7e7 > src/master/master.cpp 76e217d16c03e587ea4c0afca94c58b2212f0f93 > src/tests/hook_tests.cpp f4b4f519456dc00a8894c7ce154b28a7ab9ce493 > > Diff: https://reviews.apache.org/r/30961/diff/ > > > Testing > ------- > > make check (with modified VerifyMasterLaunchTaskHook test) > > > Thanks, > > Niklas Nielsen > >
