> On Feb. 27, 2015, 5:17 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp, line 300 > > <https://reviews.apache.org/r/31470/diff/1-2/?file=877501#file877501line300> > > > > too soon. you'll free this then access addr which is a pointer in ifa > > which is part of ifaddr. > > > > make the call to try to create the IPNetwork, then free ifaddr before > > checking the error.
ups, I changed this in the next patches. - Evelina ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31470/#review74510 ----------------------------------------------------------- On Feb. 27, 2015, 6:52 a.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31470/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2015, 6:52 a.m.) > > > Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van > Remoortere, and Niklas Nielsen. > > > Repository: mesos > > > Description > ------- > > see summary > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp > 3293086a009a8f7cf7bd343eb7d3e85623636550 > 3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp > fb98317a68986cb1228c584a8cd83b07737895a8 > > Diff: https://reviews.apache.org/r/31470/diff/ > > > Testing > ------- > > > Thanks, > > Evelina Dumitrescu > >
