----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31470/#review74535 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp <https://reviews.apache.org/r/31470/#comment121126> Can you remove the comment "(in host order)" if the parameter is an `IP`? It's impl. details of `IP` and should not concern `IPNetwork`? Here and everywhere else. Thanks! 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp <https://reviews.apache.org/r/31470/#comment121127> any reason change the prefix from size_t to int? Prefix cannot be negative, right? 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp <https://reviews.apache.org/r/31470/#comment121128> Here is a bug right? The prefix can be negative if you use 'int'. So please revert it back to size_t. 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp <https://reviews.apache.org/r/31470/#comment121129> s/ip/network/ or s/ip/subnet/ 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp <https://reviews.apache.org/r/31470/#comment121130> This can be merged to one line: return stream << network.address() << "/" << network.prefix(); 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp <https://reviews.apache.org/r/31470/#comment121131> "but does not have an IP network" 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp <https://reviews.apache.org/r/31470/#comment121132> s/ip/network/ or s/ip/subnet/ - Jie Yu On Feb. 27, 2015, 6:52 a.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31470/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2015, 6:52 a.m.) > > > Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van > Remoortere, and Niklas Nielsen. > > > Repository: mesos > > > Description > ------- > > see summary > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp > 3293086a009a8f7cf7bd343eb7d3e85623636550 > 3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp > fb98317a68986cb1228c584a8cd83b07737895a8 > > Diff: https://reviews.apache.org/r/31470/diff/ > > > Testing > ------- > > > Thanks, > > Evelina Dumitrescu > >
