----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/#review72835 -----------------------------------------------------------
src/master/http.cpp <https://reviews.apache.org/r/30612/#comment118943> This fits on one line and you need to bring the '{' down on it's own line. Here and below. src/master/http.cpp <https://reviews.apache.org/r/30612/#comment121934> This fits on a single line src/master/http.cpp <https://reviews.apache.org/r/30612/#comment120953> '{' on newline. src/master/http.cpp <https://reviews.apache.org/r/30612/#comment120957> Think we can be a bit more concise. How about using a table? Request Result /master/frameworks List of all active frameworks /master/frameworks/{id}List of all tasks And so on. src/master/http.cpp <https://reviews.apache.org/r/30612/#comment120954> '..related to the registered frameworks the assigned tasks...' Not completely sure I understand that sentence. Can you rework it a little bit? :) src/master/http.cpp <https://reviews.apache.org/r/30612/#comment120955> Which endpoints? src/master/http.cpp <https://reviews.apache.org/r/30612/#comment120956> 'only de destription' s/de/the/? src/master/http.cpp <https://reviews.apache.org/r/30612/#comment120958> s/words/tokens/ src/master/http.cpp <https://reviews.apache.org/r/30612/#comment120962> Mind throwing in a comment on the three different scenarios and how it translates to your code? src/tests/master_tests.cpp <https://reviews.apache.org/r/30612/#comment118948> Needs to be 4 indent for argument wrapping - Niklas Nielsen On Feb. 16, 2015, 6:49 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30612/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2015, 6:49 a.m.) > > > Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff. > > > Bugs: MESOS-2157 > https://issues.apache.org/jira/browse/MESOS-2157 > > > Repository: mesos > > > Description > ------- > > Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}. > > Works with [29883](https://reviews.apache.org/r/29883). > > Builds on the abandoned patch 14286. > > > Diffs > ----- > > src/master/http.cpp 5e3afdf > src/master/master.hpp 6a39df0 > src/master/master.cpp f10a3cf > src/tests/master_tests.cpp e69a7fb > > Diff: https://reviews.apache.org/r/30612/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
