> On Feb. 14, 2015, 12:47 a.m., Ben Mahler wrote: > > I only took a quick glance, so apologies in advance if I'm missing > > something. Is it possible to consolidate the tests (perhaps you can make > > several requests inside the same test?). 1000 lines of test code seems like > > a big maintenance burden. :)
So, at the end I implemented a test fixture in order to reduce the size of the tests. At the end, half of the code was initialization and destruction of the environment. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/#review72453 ----------------------------------------------------------- On Feb. 16, 2015, 3:49 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30612/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2015, 3:49 p.m.) > > > Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff. > > > Bugs: MESOS-2157 > https://issues.apache.org/jira/browse/MESOS-2157 > > > Repository: mesos > > > Description > ------- > > Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}. > > Works with [29883](https://reviews.apache.org/r/29883). > > Builds on the abandoned patch 14286. > > > Diffs > ----- > > src/master/http.cpp 5e3afdf > src/master/master.hpp 6a39df0 > src/master/master.cpp f10a3cf > src/tests/master_tests.cpp e69a7fb > > Diff: https://reviews.apache.org/r/30612/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
