----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31776/#review75894 -----------------------------------------------------------
include/mesos/master/allocator.proto <https://reviews.apache.org/r/31776/#comment123311> Can you add a comment on why this is in internal src/Makefile.am <https://reviews.apache.org/r/31776/#comment123221> Let's keep this sorted src/Makefile.am <https://reviews.apache.org/r/31776/#comment123222> Let's keep this ordering in sync with the list above src/Makefile.am <https://reviews.apache.org/r/31776/#comment123223> Again, let's keep ordering :) src/local/local.hpp <https://reviews.apache.org/r/31776/#comment123227> Can we include the allocator and master header instead? src/local/local.hpp <https://reviews.apache.org/r/31776/#comment123226> Let's create a JIRA ticket for the namespace rules and get it in the style guide. I initially found it hard to read with the new line here, but after a conversation offline, I found that it's a rule we (mostly) apply: group namespace beginnings when they are closed together: namespace A { namespace B { namespace C { } // namespace B { } // namespace C { namespace D { } // namespace D { } // namespace A { src/master/allocator/allocator.hpp <https://reviews.apache.org/r/31776/#comment123312> Let's move the comment above and insert a newline below src/master/master.hpp <https://reviews.apache.org/r/31776/#comment123228> Why do you need this forward declaration when you have the allocator include? - Niklas Nielsen On March 5, 2015, 1:11 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31776/ > ----------------------------------------------------------- > > (Updated March 5, 2015, 1:11 p.m.) > > > Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen. > > > Bugs: MESOS-2160 > https://issues.apache.org/jira/browse/MESOS-2160 > > > Repository: mesos > > > Description > ------- > > This is required for out-of-tree allocator modules. RoleInfo protobuf message > has to be extracted into its own public proto file. > > > Diffs > ----- > > include/mesos/master/allocator.proto PRE-CREATION > src/Makefile.am d299f07d865080676ca8a550cf6005c6ab32839f > src/local/local.hpp 0aa50ef4f44c347eca4b3a409f2a8d03ba321d82 > src/local/local.cpp 19083368212b24ce1afef3a5f91d48766d1cd55e > src/master/allocator/allocator.hpp b67b8fddbd7a3fffc6fe24d5e77cd1db8cb6f69b > src/master/allocator/mesos/allocator.hpp > fb898f1175b61b442204e6e38c69ccc2838a646f > src/master/main.cpp 7cce3a0bb808a1cb7bac9acab31eb1c67a15ea9f > src/master/master.hpp 3c957abcb54a0c23b8549c1d21d2d9277791938d > src/master/master.cpp 68ca19a9ae680e3ae5bd433a9842baf69f2360ec > src/messages/messages.proto 97c45c01dfcea38b1ae555c036d61e10c152c2c8 > src/tests/cluster.hpp a56b6541adcdebc5866571bbdbb6828df97b34ec > src/tests/fault_tolerance_tests.cpp > 9ac75b1f601e14a3d3d117775f37a4a48b291dc6 > src/tests/hierarchical_allocator_tests.cpp > 93753d1c04159a04a733927a487eb69505438e32 > src/tests/master_allocator_tests.cpp > a432d0207e1a92532a495bf9ad2826414ee4f6f0 > src/tests/master_authorization_tests.cpp > ff706ed6f8537207b30a548b0ce2121c5df71ab9 > src/tests/master_slave_reconciliation_tests.cpp > e60f601202fcdbb4cafac190e9b09ca6ce925260 > src/tests/master_tests.cpp 580e1f818201f951c11e4e652a7941fcd888356d > src/tests/mesos.hpp 45e35204d1aa876fa0c871acf0f21afcd5ababe8 > src/tests/mesos.cpp c8f43d21b214e75eaac2870cbdf4f03fd18707d1 > src/tests/rate_limiting_tests.cpp d5c00b8db30fc529bc984417a632cf99eb50eb28 > > Diff: https://reviews.apache.org/r/31776/diff/ > > > Testing > ------- > > make check (Mac OS 10.9.5, Ubuntu 14.04) > > > Thanks, > > Alexander Rukletsov > >
