> On March 23, 2015, 6:27 p.m., Michael Park wrote: > > src/Makefile.am, lines 234-239 > > <https://reviews.apache.org/r/31776/diff/4/?file=902996#file902996line234> > > > > In line with the above comment, it seems like `$(ALLOCATOR_PROTO)` > > should live in `include/mesos/allocator/...` rather than > > `include/mesos/master/...`. Similar to `authentication`, `containerizer`, > > and `fetcher`.
The allocator proto should live in include/mesos/master since it's specific to mesos master. The containerizer/fetcher protos are for framework writers and are in their own subdirs for historic reasons. The authentication stuff used by both master and slave and hence in its own subdir. The correct precedence for this would be the stuff in include/mesos/slave. > On March 23, 2015, 6:27 p.m., Michael Park wrote: > > src/Makefile.am, lines 170-171 > > <https://reviews.apache.org/r/31776/diff/4/?file=902996#file902996line170> > > > > Seems to me like these should be `allocator/allocator.pb.cc`, and > > `../include/mesos/allocator/allocator.pb.h`. Could you explain why these > > are under `master`? See below. - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31776/#review77477 ----------------------------------------------------------- On March 23, 2015, 10:02 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31776/ > ----------------------------------------------------------- > > (Updated March 23, 2015, 10:02 a.m.) > > > Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen. > > > Bugs: MESOS-2160 > https://issues.apache.org/jira/browse/MESOS-2160 > > > Repository: mesos > > > Description > ------- > > This is required for out-of-tree allocator modules. RoleInfo protobuf message > has to be extracted into its own public proto file. > > > Diffs > ----- > > include/mesos/master/allocator.proto PRE-CREATION > src/Makefile.am 7a06c7028eca8164b1f5fdea6a7ecd37ee6826bb > src/local/local.hpp 0aa50ef4f44c347eca4b3a409f2a8d03ba321d82 > src/local/local.cpp 19083368212b24ce1afef3a5f91d48766d1cd55e > src/master/allocator/allocator.hpp b67b8fddbd7a3fffc6fe24d5e77cd1db8cb6f69b > src/master/allocator/mesos/allocator.hpp > fb898f1175b61b442204e6e38c69ccc2838a646f > src/master/main.cpp 7cce3a0bb808a1cb7bac9acab31eb1c67a15ea9f > src/master/master.hpp 3c957abcb54a0c23b8549c1d21d2d9277791938d > src/master/master.cpp dccd7c635da4b7031cd109bd84e7f17b31777ef1 > src/messages/messages.proto 97c45c01dfcea38b1ae555c036d61e10c152c2c8 > src/tests/cluster.hpp a56b6541adcdebc5866571bbdbb6828df97b34ec > src/tests/fault_tolerance_tests.cpp > 9ac75b1f601e14a3d3d117775f37a4a48b291dc6 > src/tests/hierarchical_allocator_tests.cpp > 93753d1c04159a04a733927a487eb69505438e32 > src/tests/master_allocator_tests.cpp > a432d0207e1a92532a495bf9ad2826414ee4f6f0 > src/tests/master_authorization_tests.cpp > ff706ed6f8537207b30a548b0ce2121c5df71ab9 > src/tests/master_slave_reconciliation_tests.cpp > e60f601202fcdbb4cafac190e9b09ca6ce925260 > src/tests/master_tests.cpp e69348be676a80017062e3abbd15b8008a6009d7 > src/tests/mesos.hpp 45e35204d1aa876fa0c871acf0f21afcd5ababe8 > src/tests/mesos.cpp c8f43d21b214e75eaac2870cbdf4f03fd18707d1 > src/tests/rate_limiting_tests.cpp d5c00b8db30fc529bc984417a632cf99eb50eb28 > > Diff: https://reviews.apache.org/r/31776/diff/ > > > Testing > ------- > > make check (Mac OS 10.9.5, CentOS 7.0) > > > Thanks, > > Alexander Rukletsov > >
