----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31889/#review76035 -----------------------------------------------------------
Bad patch! Reviews applied: [31889] Failed command: ./support/apply-review.sh -n -r 31889 Error: 2015-03-11 02:34:57 URL:https://reviews.apache.org/r/31889/diff/raw/ [12515/12515] -> "31889.patch" [1] error: patch failed: src/examples/test_hook_module.cpp:101 error: src/examples/test_hook_module.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On March 11, 2015, 2:15 a.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31889/ > ----------------------------------------------------------- > > (Updated March 11, 2015, 2:15 a.m.) > > > Review request for mesos, Adam B, Ben Mahler, Niklas Nielsen, and Till > Toenshoff. > > > Bugs: MESOS-2463 > https://issues.apache.org/jira/browse/MESOS-2463 > > > Repository: mesos > > > Description > ------- > > The ExecutorInfo is immutable, and so the environment decoration is deferred > until containerizer launch. The new slaveExecutorHook simply notifies the hook > module of a new executor being launched. The environment decorator hook for > containerizer launch update it's environment variables as gathered from the > hook > modules. > > > Diffs > ----- > > include/mesos/hook.hpp d83ace576a2c78eb7b1e910d89d912f6df5c46ef > src/examples/test_hook_module.cpp 8faf6850aafcebda7e9f0d1b735d61f7effa842d > src/hook/manager.hpp d3729eaca1bf2893cbc94cf62835dafb2d9a22a1 > src/hook/manager.cpp 3fd9d5e7f81e3d0ca2aca4091beba4ae555ae7e7 > src/slave/containerizer/containerizer.cpp > 33f8738fa229b42ebacfd75b762c977b33191b65 > src/slave/slave.cpp 364d911b086dfe1f15f76aa3888f99146aa8d876 > src/tests/hook_tests.cpp f4b4f519456dc00a8894c7ce154b28a7ab9ce493 > > Diff: https://reviews.apache.org/r/31889/diff/ > > > Testing > ------- > > make check. The master failover tests have not been performed yet. > > > Thanks, > > Kapil Arya > >
