----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31889/#review76049 -----------------------------------------------------------
Looks good. Just a couple of questions and some style nits in the new test. src/hook/manager.cpp <https://reviews.apache.org/r/31889/#comment123441> What should you do if result.isNone()? Just ignore without warning (as you're already doing here)? src/tests/hook_tests.cpp <https://reviews.apache.org/r/31889/#comment123448> Does this being a HookTest mean that it's guaranteed to use the "FOO=bar" test executorEnvironmentDecorator hook? src/tests/hook_tests.cpp <https://reviews.apache.org/r/31889/#comment123442> >> src/tests/hook_tests.cpp <https://reviews.apache.org/r/31889/#comment123443> >> src/tests/hook_tests.cpp <https://reviews.apache.org/r/31889/#comment123444> .Times(1) is implicit, can be removed. src/tests/hook_tests.cpp <https://reviews.apache.org/r/31889/#comment123445> >> src/tests/hook_tests.cpp <https://reviews.apache.org/r/31889/#comment123449> Where do you actually validate the return value here? Is it just that you're expecting TASK_FINISHED instead of TASK_FAILED? src/tests/hook_tests.cpp <https://reviews.apache.org/r/31889/#comment123446> s/MergeFrom/CopyFrom/g src/tests/hook_tests.cpp <https://reviews.apache.org/r/31889/#comment123447> Could use the CREATE_EXECUTOR_INFO() + LaunchTasks() model instead of building up a TaskInfo yourself. - Adam B On March 10, 2015, 7:15 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31889/ > ----------------------------------------------------------- > > (Updated March 10, 2015, 7:15 p.m.) > > > Review request for mesos, Adam B, Ben Mahler, Niklas Nielsen, and Till > Toenshoff. > > > Bugs: MESOS-2463 > https://issues.apache.org/jira/browse/MESOS-2463 > > > Repository: mesos > > > Description > ------- > > The ExecutorInfo is immutable, and so the environment decoration is deferred > until containerizer launch. The new slaveExecutorHook simply notifies the hook > module of a new executor being launched. The environment decorator hook for > containerizer launch update it's environment variables as gathered from the > hook > modules. > > > Diffs > ----- > > include/mesos/hook.hpp d83ace576a2c78eb7b1e910d89d912f6df5c46ef > src/examples/test_hook_module.cpp 8faf6850aafcebda7e9f0d1b735d61f7effa842d > src/hook/manager.hpp d3729eaca1bf2893cbc94cf62835dafb2d9a22a1 > src/hook/manager.cpp 3fd9d5e7f81e3d0ca2aca4091beba4ae555ae7e7 > src/slave/containerizer/containerizer.cpp > 33f8738fa229b42ebacfd75b762c977b33191b65 > src/slave/slave.cpp 364d911b086dfe1f15f76aa3888f99146aa8d876 > src/tests/hook_tests.cpp f4b4f519456dc00a8894c7ce154b28a7ab9ce493 > > Diff: https://reviews.apache.org/r/31889/diff/ > > > Testing > ------- > > make check. The master failover tests have not been performed yet. > > > Thanks, > > Kapil Arya > >
