> On March 11, 2015, 6:01 p.m., Jie Yu wrote: > > src/common/type_utils.cpp, lines 145-160 > > <https://reviews.apache.org/r/31905/diff/2/?file=890906#file890906line145> > > > > Looks like we have the same logic for many repeated fields here. I am > > wondering if we can have a helper function: > > ``` > > template <typename T> > > bool equivalent( > > const RepeatedField<T>& left, > > const RepeatedField<T>& right, > > bool checkOrder = false) > > { > > if (left.size() != right.size()) { > > return false; > > } > > > > for (int i = 0; i < left.size(); i++) { > > ... > > } > > > > ... > > } > > ```
I'll add a TODO for now. I will fix this as part of: https://issues.apache.org/jira/browse/MESOS-2487 - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31905/#review76084 ----------------------------------------------------------- On March 11, 2015, 12:37 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31905/ > ----------------------------------------------------------- > > (Updated March 11, 2015, 12:37 a.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, Joerg Schad, and Timothy Chen. > > > Bugs: MESOS-2309 > https://issues.apache.org/jira/browse/MESOS-2309 > > > Repository: mesos > > > Description > ------- > > When new fields were added to protobufs these operators were not updated. > Fixed now. > > > Diffs > ----- > > src/common/type_utils.cpp a1704c67d04d19f65d94dbe56a61bb28561e5bf3 > > Diff: https://reviews.apache.org/r/31905/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
