> On March 13, 2015, 9:52 a.m., Alexander Rojas wrote: > > src/common/type_utils.cpp, lines 331-342 > > <https://reviews.apache.org/r/31905/diff/3/?file=892475#file892475line331> > > > > This change breaks the build if using warnings as errors, since you add > > a `;` and then you compare the rest of the fields. > > Alexander Rojas wrote: > Actually, it just breaks the build on OSX (or clang based builds). The > exact warning is: Unused expression result.
Fixed in https://reviews.apache.org/r/32034/. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31905/#review76347 ----------------------------------------------------------- On March 12, 2015, 11:20 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31905/ > ----------------------------------------------------------- > > (Updated March 12, 2015, 11:20 p.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, Joerg Schad, and Timothy Chen. > > > Bugs: MESOS-2309 > https://issues.apache.org/jira/browse/MESOS-2309 > > > Repository: mesos > > > Description > ------- > > When new fields were added to protobufs these operators were not updated. > Fixed now. > > > Diffs > ----- > > src/common/type_utils.cpp a1704c67d04d19f65d94dbe56a61bb28561e5bf3 > > Diff: https://reviews.apache.org/r/31905/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
