> On March 10, 2015, 9:11 p.m., Niklas Nielsen wrote: > > How about we try to make this look like the Containerizer factory-like > > method (Containerizer::create)? That would be a bit more consistent
I think `Containerizer` is not a good example here. I would rather point to `Authenticator` and / or `Authenticatee`. We do not have `.create()` methods there, but we check in slave and master code whether we have modules for them. Therefore, I do not think we need a `.create()` function for `Allocator`. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31265/#review75978 ----------------------------------------------------------- On March 5, 2015, 9:07 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31265/ > ----------------------------------------------------------- > > (Updated March 5, 2015, 9:07 p.m.) > > > Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen. > > > Bugs: MESOS-2160 > https://issues.apache.org/jira/browse/MESOS-2160 > > > Repository: mesos > > > Description > ------- > > The factory creates allocator instances in a way identical to how instances > from modules are created. It allows us to use same typed tests for built-in > and modularized allocators. > > > Diffs > ----- > > src/tests/master_allocator_tests.cpp > a432d0207e1a92532a495bf9ad2826414ee4f6f0 > > Diff: https://reviews.apache.org/r/31265/diff/ > > > Testing > ------- > > make check (Mac OS 10.9.5, Ubuntu 14.04) > > > Thanks, > > Alexander Rukletsov > >
