> On March 24, 2015, 2:41 p.m., Michael Park wrote: > > src/tests/master_allocator_tests.cpp, line 97 > > <https://reviews.apache.org/r/31265/diff/4/?file=903029#file903029line97> > > > > 1. Do we need this to be `virtual` right now? > > 2. `s/createAllocatorInstance/CreateAllocator/` > > 3. Can we move this either above `SetUp` or below `TearDown`? seems > > weird to have it sitting in the middle. > > Alexander Rukletsov wrote: > 1. I though it make sense to mark it virtual, but I'll remove it if you > think it's cleaner. > 2. We use `camelCase` > 3. Sure.
1. It wasn't about cleanliness, but rather that I don't think `createAllocator` is a function that should have polymorphic behavior. 2. Seems like we're inconsistent yet again. `src/tests/mesos.hpp` introduces a bunch of non-gtest functions such as `CreateMasterFlags` which are title-cased (I guess to keep consistent with gtest functions). `src/tests/persistent_volumes_tests.cpp` for example kept this pattern and has title-cased functions, but other tests such as `DockerContainerizerTest` in `src/tests/docker_containerizer_tests.cpp` did not. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31265/#review77570 ----------------------------------------------------------- On March 27, 2015, 4:27 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31265/ > ----------------------------------------------------------- > > (Updated March 27, 2015, 4:27 p.m.) > > > Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen. > > > Bugs: MESOS-2160 > https://issues.apache.org/jira/browse/MESOS-2160 > > > Repository: mesos > > > Description > ------- > > The factory creates allocator instances in a way identical to how instances > from modules are created. It allows us to use same typed tests for built-in > and modularized allocators. > > > Diffs > ----- > > src/master/allocator/mesos/allocator.hpp > fb898f1175b61b442204e6e38c69ccc2838a646f > src/tests/master_allocator_tests.cpp > 03a1bb8c92b44bc1ad1b5f5cff8d1fb971df2302 > > Diff: https://reviews.apache.org/r/31265/diff/ > > > Testing > ------- > > make check (Mac OS 10.9.5, Ubuntu 14.04) > > > Thanks, > > Alexander Rukletsov > >
