----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31838/#review76464 -----------------------------------------------------------
Ship it! src/slave/slave.cpp <https://reviews.apache.org/r/31838/#comment124010> Does it make sense to flatten this for readability? Like this: ``` } else if (info.has_id()) { ... } else { ... } ``` - Alexander Rukletsov On March 9, 2015, 12:54 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31838/ > ----------------------------------------------------------- > > (Updated March 9, 2015, 12:54 a.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Vinod > Kone. > > > Bugs: MESOS-2464 > https://issues.apache.org/jira/browse/MESOS-2464 > > > Repository: mesos-incubating > > > Description > ------- > > see summary. > > > Diffs > ----- > > src/slave/slave.cpp 364d911 > > Diff: https://reviews.apache.org/r/31838/diff/ > > > Testing > ------- > > make check && functional testing with failed authentication > > > Thanks, > > Till Toenshoff > >
