----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31838/#review78226 -----------------------------------------------------------
I think the bigger problem here is that slave shuts down all the running tasks and executors if authentication fails. I think that is dangerous. For example if the master is misconfigured with wrong credentials, this could potentially shut down the whole cluster! I think the safer thing to do is to EXIT(1) in _authenticate() instead of shutdown(). - Vinod Kone On March 9, 2015, 12:54 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31838/ > ----------------------------------------------------------- > > (Updated March 9, 2015, 12:54 a.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Vinod > Kone. > > > Bugs: MESOS-2464 > https://issues.apache.org/jira/browse/MESOS-2464 > > > Repository: mesos-incubating > > > Description > ------- > > see summary. > > > Diffs > ----- > > src/slave/slave.cpp 364d911 > > Diff: https://reviews.apache.org/r/31838/diff/ > > > Testing > ------- > > make check && functional testing with failed authentication > > > Thanks, > > Till Toenshoff > >
