----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31915/#review76770 -----------------------------------------------------------
include/mesos/mesos.proto <https://reviews.apache.org/r/31915/#comment124434> For protobuf you cannot re-use tags, they must refer to the same field name or, if they were optional, then you can drop them. See "Assigning Tags" [here|https://developers.google.com/protocol-buffers/docs/proto] include/mesos/mesos.proto <https://reviews.apache.org/r/31915/#comment124435> ditto include/mesos/mesos.proto <https://reviews.apache.org/r/31915/#comment124436> ditto include/mesos/mesos.proto <https://reviews.apache.org/r/31915/#comment124437> double negatives are confusing ;-) // This is only set if swap is enabled. src/slave/containerizer/isolators/cgroups/mem.cpp <https://reviews.apache.org/r/31915/#comment124440> Be explicit that mem_file_bytes is deprecated, otherwise it could be interpreted as all of this block. src/slave/containerizer/isolators/cgroups/mem.cpp <https://reviews.apache.org/r/31915/#comment124439> Be explicit that mem_anon_bytes is deprecated, otherwise it could be interpreted as all of this block. src/slave/containerizer/isolators/cgroups/mem.cpp <https://reviews.apache.org/r/31915/#comment124441> if this conditional on limitSwap? - Ian Downes On March 10, 2015, 4:55 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31915/ > ----------------------------------------------------------- > > (Updated March 10, 2015, 4:55 p.m.) > > > Review request for mesos and Ian Downes. > > > Bugs: mesos-2104 > https://issues.apache.org/jira/browse/mesos-2104 > > > Repository: mesos > > > Description > ------- > > MemIsolator: Improved some statistics naming. (MESOS-2104) > > > Diffs > ----- > > include/mesos/mesos.proto 9df972d750ce1e4a81d2e96cc508d6f83cad2fc8 > src/slave/containerizer/isolators/cgroups/mem.cpp > 6299ca4ba01b65daa3d75c64150e2738e32b841e > > Diff: https://reviews.apache.org/r/31915/diff/ > > > Testing > ------- > > > Thanks, > > Chi Zhang > >
