----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31915/#review79424 -----------------------------------------------------------
Ship it! Looks good. Before we can commit this, can you please ping the dev and user lists to notify people of the change, detailing exactly what is being done. And ensure this is included in the documentation for the 0.23.0 release (or whichever release it goes into). include/mesos/mesos.proto <https://reviews.apache.org/r/31915/#comment128769> 0.23.0 include/mesos/mesos.proto <https://reviews.apache.org/r/31915/#comment128778> Is this correct? I thought it was the following: mem_total_bytes was added 0.23.0 to report the total memory usage of the cgroup. This was previously reported as mem_rss_bytes which is now changed to report only anonymous memory usage, ... include/mesos/mesos.proto <https://reviews.apache.org/r/31915/#comment128768> s/Linux/linux include/mesos/mesos.proto <https://reviews.apache.org/r/31915/#comment128782> Match your comment below, "This is only set if swap is enabled." include/mesos/mesos.proto <https://reviews.apache.org/r/31915/#comment128780> Please file a ticket for this. include/mesos/mesos.proto <https://reviews.apache.org/r/31915/#comment128781> Note that neither its type, name nor numeric tag has been changed. - Ian Downes On April 1, 2015, 3:28 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31915/ > ----------------------------------------------------------- > > (Updated April 1, 2015, 3:28 p.m.) > > > Review request for mesos, Ian Downes and Paul Brett. > > > Bugs: mesos-2104 > https://issues.apache.org/jira/browse/mesos-2104 > > > Repository: mesos > > > Description > ------- > > MemIsolator: Improved some statistics naming. (MESOS-2104) > > > Diffs > ----- > > include/mesos/mesos.proto 3a8e8bf303e0576c212951f6028af77e54d93537 > src/slave/containerizer/isolators/cgroups/mem.cpp > a7a83ef9ad4726aa139a92fc7f5917ed687d33f5 > > Diff: https://reviews.apache.org/r/31915/diff/ > > > Testing > ------- > > > Thanks, > > Chi Zhang > >
