> On March 24, 2015, 7:25 a.m., Timothy Chen wrote: > > include/mesos/mesos.proto, line 397 > > <https://reviews.apache.org/r/32139/diff/2/?file=899198#file899198line397> > > > > Not sure this is the right place to comment on the valid specifications > > of both role and reservation. There is a user guide added right? We should > > refer to that instead.
Hm, the user guide doesn't exist in the repo. Maybe we just say something like: "Refer to the reservations user guide for the valid states and transitions of (role, reservation) pair." and add in the links together with the user guide later? > On March 24, 2015, 7:25 a.m., Timothy Chen wrote: > > include/mesos/mesos.proto, line 428 > > <https://reviews.apache.org/r/32139/diff/2/?file=899198#file899198line428> > > > > It also can be unreserved as well? If the `reservation` is not set, it's either "statically reserved" or "unreserved". I cheated here by saying "statically configured", perhaps that's confusing. I'll explicitly mention "statically reserved" and "unreserved". - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32139/#review77536 ----------------------------------------------------------- On March 18, 2015, 7:43 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32139/ > ----------------------------------------------------------- > > (Updated March 18, 2015, 7:43 p.m.) > > > Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu. > > > Bugs: MESOS-2475 > https://issues.apache.org/jira/browse/MESOS-2475 > > > Repository: mesos > > > Description > ------- > > The beginning of `Resource::ReservationInfo`. This patch only introduces the > `framework_id` field. We don't need the required `principal` field yet and > will be introduced together with the "unreserve" ACLs. An optional `id` may > be introduced in the future as well. > > > Diffs > ----- > > include/mesos/mesos.proto ec8efaec13f54a56d82411f6cdbdb8ad8b103748 > > Diff: https://reviews.apache.org/r/32139/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
