> On April 15, 2015, 5:35 p.m., Alexander Rukletsov wrote: > > include/mesos/mesos.proto, line 409 > > <https://reviews.apache.org/r/32139/diff/4/?file=920079#file920079line409> > > > > While `required` here, `principal` is `optional` in `FrameworkInfo`. > > Let's update the comment there to hint folks they should provide > > `principal` of they want their framework to reserve resources.
Updated the comment for `FrameworkInfo`. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32139/#review80198 ----------------------------------------------------------- On April 21, 2015, 8:35 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32139/ > ----------------------------------------------------------- > > (Updated April 21, 2015, 8:35 p.m.) > > > Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu. > > > Bugs: MESOS-2475 > https://issues.apache.org/jira/browse/MESOS-2475 > > > Repository: mesos > > > Description > ------- > > The beginning of `Resource::ReservationInfo`. This patch only introduces the > `principal` field. > > > Diffs > ----- > > include/mesos/mesos.proto 3a8e8bf303e0576c212951f6028af77e54d93537 > > Diff: https://reviews.apache.org/r/32139/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
