----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32500/#review77836 -----------------------------------------------------------
Ship it! include/mesos/scheduler/scheduler.proto <https://reviews.apache.org/r/32500/#comment126165> Ditto here, the tag numbers don't matter much, but are you planning to fill in the holes since we're breaking this? include/mesos/scheduler/scheduler.proto <https://reviews.apache.org/r/32500/#comment126164> Just curious, are you planning on updating the tag numbers at some point or just going to leave the holes? src/examples/low_level_scheduler_libprocess.cpp <https://reviews.apache.org/r/32500/#comment126163> Ditto here, maybe some newlines to make this a bit more readable? src/examples/low_level_scheduler_pthread.cpp <https://reviews.apache.org/r/32500/#comment126160> newline here? src/examples/low_level_scheduler_pthread.cpp <https://reviews.apache.org/r/32500/#comment126161> newline here? src/examples/low_level_scheduler_pthread.cpp <https://reviews.apache.org/r/32500/#comment126162> newline here? src/tests/scheduler_tests.cpp <https://reviews.apache.org/r/32500/#comment126158> newline here? src/tests/scheduler_tests.cpp <https://reviews.apache.org/r/32500/#comment126159> newline here? - Ben Mahler On March 25, 2015, 11:06 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32500/ > ----------------------------------------------------------- > > (Updated March 25, 2015, 11:06 p.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Bugs: MESOS-1127 > https://issues.apache.org/jira/browse/MESOS-1127 > > > Repository: mesos > > > Description > ------- > > Removed LAUNCH call in favor of ACCEPT. > > > Diffs > ----- > > include/mesos/scheduler/scheduler.proto > 783a63ad1cc0edd86605d638046fb959cb6e97e8 > src/examples/low_level_scheduler_libprocess.cpp > 63d34eefb60d13fe2b82905c1cec9b762340e997 > src/examples/low_level_scheduler_pthread.cpp > 6d1f938660c02db75bfcbf7c8de0d941cff1920d > src/master/master.cpp dccd7c635da4b7031cd109bd84e7f17b31777ef1 > src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a > src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657 > > Diff: https://reviews.apache.org/r/32500/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
