----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32500/#review79351 -----------------------------------------------------------
include/mesos/scheduler/scheduler.proto <https://reviews.apache.org/r/32500/#comment128617> FYI: this looks too long for a comment, clang-format shouldn't allow this. I think this is OK though, and helps readability. include/mesos/scheduler/scheduler.proto <https://reviews.apache.org/r/32500/#comment128614> Do we specify an order in which offer operations are performed? I don't think you touched this in the design doc. Mind leaving a comment whether we provide any guarantees here? src/scheduler/scheduler.cpp <https://reviews.apache.org/r/32500/#comment128615> IIUC, since this is not migrated to `case Call::ACCEPT`, tasks are launched via `Master::accept()` and not via `Master::launchTasks()`. If this is the case, then it looks like we do not update some metrics, namely: `++metrics->messages_launch_tasks;` `++metrics->messages_decline_offers;` Do you plan to adress this later on or am I missing something? - Alexander Rukletsov On March 30, 2015, 11:59 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32500/ > ----------------------------------------------------------- > > (Updated March 30, 2015, 11:59 p.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Bugs: MESOS-1127 > https://issues.apache.org/jira/browse/MESOS-1127 > > > Repository: mesos > > > Description > ------- > > Removed LAUNCH call in favor of ACCEPT. > > > Diffs > ----- > > include/mesos/scheduler/scheduler.proto > 783a63ad1cc0edd86605d638046fb959cb6e97e8 > src/examples/low_level_scheduler_libprocess.cpp > 63d34eefb60d13fe2b82905c1cec9b762340e997 > src/examples/low_level_scheduler_pthread.cpp > 6d1f938660c02db75bfcbf7c8de0d941cff1920d > src/master/master.cpp 618db68ee4163b06e479cf3413eda4b63c9c5a4b > src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a > src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657 > > Diff: https://reviews.apache.org/r/32500/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
