----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32583/#review78494 -----------------------------------------------------------
Should mention in the Description (commit message) that the new preferred location for the FrameworkID is or will be in FrameworkInfo.id. Would also like for you to replace ambiguous instances of 'it' in the description with the actual field/message to which 'it' refers. src/slave/slave.cpp <https://reviews.apache.org/r/32583/#comment127312> CopyFrom? - Adam B On March 31, 2015, 1:28 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32583/ > ----------------------------------------------------------- > > (Updated March 31, 2015, 1:28 p.m.) > > > Review request for mesos, Adam B and Niklas Nielsen. > > > Bugs: MESOS-2558 > https://issues.apache.org/jira/browse/MESOS-2558 > > > Repository: mesos > > > Description > ------- > > For this release (N), we still keep setting it (handles older Slaves with > newer Master). > - Added code to handle it being unset in the Slave (handles older > Master with newer Slaves). > > In the following release (N+1), stop reading/setting it (the previous version > would handle the unset case). > > In release N+2, remove the field altogether (the previous release is not > setting/reading it). > > > Diffs > ----- > > src/messages/messages.proto 97c45c01dfcea38b1ae555c036d61e10c152c2c8 > src/slave/slave.cpp c7e65a6c095963feaa9d5fdbb519c68f8f761d16 > > Diff: https://reviews.apache.org/r/32583/diff/ > > > Testing > ------- > > make check. > > TODO: Test for upgrade path. > > > Thanks, > > Kapil Arya > >
