----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32583/#review78704 -----------------------------------------------------------
src/messages/messages.proto <https://reviews.apache.org/r/32583/#comment127658> Add deprecated tag to indicate that no one should use this going forward. It doesn't affect the C++ code and only adds @deprecated for Java. optional FrameworkID framework_id = 1 [deprecated = true]; - Joris Van Remoortere On April 1, 2015, 7:34 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32583/ > ----------------------------------------------------------- > > (Updated April 1, 2015, 7:34 p.m.) > > > Review request for mesos, Adam B and Niklas Nielsen. > > > Bugs: MESOS-2558 > https://issues.apache.org/jira/browse/MESOS-2558 > > > Repository: mesos > > > Description > ------- > > The new preferred location for FrameworkID is FrameworkInfo.id. This patchset > achieves this goal by incrementally deprecating other locations for > FrameworkID. > > Here is a plan to deal with the upgrade path: > > For this release (N), we still keep setting RunTaskMessage::framework_id > - this would handle older Slaves with newer Master. > - added code to handle it being unset in the Slave (handles older > Master with newer Slaves). > > In the following release (N+1), stop reading/setting > RunTaskMessage::framework_id > - the previous version would handle the unset case. > > In release N+2, remove the field altogether: > - the previous release is not setting/reading it. > > > Diffs > ----- > > src/messages/messages.proto 97c45c01dfcea38b1ae555c036d61e10c152c2c8 > src/slave/slave.cpp c7e65a6c095963feaa9d5fdbb519c68f8f761d16 > > Diff: https://reviews.apache.org/r/32583/diff/ > > > Testing > ------- > > make check. > > TODO: Test for upgrade path. > > > Thanks, > > Kapil Arya > >
