----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32698/#review78545 -----------------------------------------------------------
Ship it! src/linux/perf.cpp <https://reviews.apache.org/r/32698/#comment127389> Not yours but the delimiter doesn't need to be attached to the flag so it's cleaner to have it as a separate argument now: {noformat} -x SEP, --field-separator SEP print counts using a CSV-style output to make it easy to import directly into spreadsheets. Columns are separated by the string specified in SEP. {noformat} src/linux/perf.cpp <https://reviews.apache.org/r/32698/#comment127388> ditto - Ian Downes On March 31, 2015, 1:04 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32698/ > ----------------------------------------------------------- > > (Updated March 31, 2015, 1:04 p.m.) > > > Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone. > > > Bugs: MESOS-2462 > https://issues.apache.org/jira/browse/MESOS-2462 > > > Repository: mesos > > > Description > ------- > > Used the argv version of subprocess for linux perf utilities. See discussion > in MESOS-2462. This is to prepare for the death signal patch. > > > Diffs > ----- > > src/linux/perf.cpp 863aa4a972289a59f57e93cd06ba2bf9df949fe2 > > Diff: https://reviews.apache.org/r/32698/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
