> On April 1, 2015, 10:38 p.m., Ben Mahler wrote:
> > src/linux/perf.cpp, line 131
> > <https://reviews.apache.org/r/32698/diff/2/?file=912580#file912580line131>
> >
> > Do you need the named 'argv' or can you return the initializer list
> > directly?
Yes, the following code does not compile on gcc-4.4:
```
return {
...
};
```
I can do
```
return vector<string>({
...
});
```
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32698/#review78612
-----------------------------------------------------------
On April 1, 2015, 7:40 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32698/
> -----------------------------------------------------------
>
> (Updated April 1, 2015, 7:40 p.m.)
>
>
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
>
>
> Bugs: MESOS-2462
> https://issues.apache.org/jira/browse/MESOS-2462
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used the argv version of subprocess for linux perf utilities. See discussion
> in MESOS-2462. This is to prepare for the death signal patch.
>
>
> Diffs
> -----
>
> src/linux/perf.cpp 863aa4a972289a59f57e93cd06ba2bf9df949fe2
>
> Diff: https://reviews.apache.org/r/32698/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
