----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32911/#review79198 -----------------------------------------------------------
Ship it! src/slave/slave.cpp <https://reviews.apache.org/r/32911/#comment128406> getExecutorInfo() will return the ExecutorInfo if the TaskInfo includes it, otherwise it will construct one (for the command executor), taking the user from the CommandInfo, if present, otherwise this code will fallback to the user from the FrameworkInfo. - Ian Downes On April 6, 2015, 5:40 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32911/ > ----------------------------------------------------------- > > (Updated April 6, 2015, 5:40 p.m.) > > > Review request for mesos, Benjamin Hindman and Ian Downes. > > > Bugs: MESOS-2592 > https://issues.apache.org/jira/browse/MESOS-2592 > > > Repository: mesos > > > Description > ------- > > During recent refactorings, executor directory ownership was delegated to the > fetcher. However, the fetcher is not invoked if no URIs are present in the > executor or task command. This left some of these tasks broken as the > directory ownership defaulted to the mesos-slave's (root). > > > Diffs > ----- > > src/slave/containerizer/external_containerizer.cpp > 1bbd61cb096771b7e4a1350079f79a20102e78f9 > src/slave/paths.hpp 1618439d728ded347ec75317ce8dd998acd7ee94 > src/slave/paths.cpp 01ea856aa2e628d4aee5fd31f7e49d147f740e8f > src/slave/slave.cpp 521624c335b9110e12ee1ff21c3918e5af6a2bde > > Diff: https://reviews.apache.org/r/32911/diff/ > > > Testing > ------- > > Functional tests with mesos-execute and make check. Have created JIRA's for > introduction of more permission/user tests. > > > Thanks, > > Niklas Nielsen > >
