----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32911/#review79231 -----------------------------------------------------------
Patch looks great! Reviews applied: [32911] All tests passed. - Mesos ReviewBot On April 7, 2015, 6:10 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32911/ > ----------------------------------------------------------- > > (Updated April 7, 2015, 6:10 p.m.) > > > Review request for mesos, Benjamin Hindman and Ian Downes. > > > Bugs: MESOS-2592 > https://issues.apache.org/jira/browse/MESOS-2592 > > > Repository: mesos > > > Description > ------- > > During recent refactorings, executor directory ownership was delegated to the > fetcher. However, the fetcher is not invoked if no URIs are present in the > executor or task command. This left some of these tasks broken as the > directory ownership defaulted to the mesos-slave's (root). > > > Diffs > ----- > > src/slave/containerizer/external_containerizer.cpp 1bbd61c > src/slave/paths.hpp 1618439 > src/slave/paths.cpp 01ea856 > src/slave/slave.cpp 521624c > > Diff: https://reviews.apache.org/r/32911/diff/ > > > Testing > ------- > > Functional tests with mesos-execute and make check. Have created JIRA's for > introduction of more permission/user tests. > > > Thanks, > > Niklas Nielsen > >
