----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31666/#review79338 -----------------------------------------------------------
Ship it! src/master/allocator/mesos/hierarchical.hpp <https://reviews.apache.org/r/31666/#comment128606> Feel free to ignore, I leave it here for the record. We drive an effort to document how we name variables to avoid shadowing: https://reviews.apache.org/r/32536/ - Alexander Rukletsov On March 7, 2015, 10:02 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31666/ > ----------------------------------------------------------- > > (Updated March 7, 2015, 10:02 a.m.) > > > Review request for mesos, Alexander Rukletsov and Ben Mahler. > > > Bugs: MESOS-2373 > https://issues.apache.org/jira/browse/MESOS-2373 > > > Repository: mesos > > > Description > ------- > > Piped the master through by > `s/sum(framework->usedResources.values())/framework->usedResources/` > Lots of `s/Resources()/hashmap<SlaveID, Resources>()/` in > `src/tests/hierarchical_allocator_tests.cpp`. > > > Diffs > ----- > > src/master/allocator/allocator.hpp b67b8fddbd7a3fffc6fe24d5e77cd1db8cb6f69b > src/master/allocator/mesos/allocator.hpp > fb898f1175b61b442204e6e38c69ccc2838a646f > src/master/allocator/mesos/hierarchical.hpp > c0b1da75565d9dc7728c5566f01815234163fc47 > src/master/master.cpp 68ca19a9ae680e3ae5bd433a9842baf69f2360ec > src/tests/hierarchical_allocator_tests.cpp > 93753d1c04159a04a733927a487eb69505438e32 > src/tests/mesos.hpp 45e35204d1aa876fa0c871acf0f21afcd5ababe8 > > Diff: https://reviews.apache.org/r/31666/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
