> On April 15, 2015, 7:35 p.m., Ben Mahler wrote:
> > src/master/allocator/mesos/hierarchical.hpp, line 313
> > <https://reviews.apache.org/r/31666/diff/4/?file=927423#file927423line313>
> >
> >     Should there be a TODO here related to what needs to be done?

Added a TODO.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31666/#review80257
-----------------------------------------------------------


On April 17, 2015, 4:31 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31666/
> -----------------------------------------------------------
> 
> (Updated April 17, 2015, 4:31 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-2373
>     https://issues.apache.org/jira/browse/MESOS-2373
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Piped the master through by 
> `s/framework->usedResources/framework->usedResourcesBySlaveId/`
> Lots of `s/Resources()/hashmap<SlaveID, Resources>()/` in 
> `src/tests/hierarchical_allocator_tests.cpp`.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/allocator.hpp 91f80501aa9bc733fd53f9cb1ac0f15949a74964 
>   src/master/allocator/mesos/allocator.hpp 
> fb898f1175b61b442204e6e38c69ccc2838a646f 
>   src/master/allocator/mesos/hierarchical.hpp 
> 9f9a631ee52a3ab194e678f9be139e8dabc7f3db 
>   src/master/master.cpp 02f35ac2d98d288bf9d2b9195770b839bbfe6d7a 
>   src/tests/hierarchical_allocator_tests.cpp 
> 8861bf398e4bb17b0f74eab4f4af26202447ccef 
>   src/tests/mesos.hpp 42e42ac425a448fcc5e93db1cef1112cbf5e67c4 
> 
> Diff: https://reviews.apache.org/r/31666/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Reply via email to