> On April 21, 2015, 6:03 a.m., Timothy Chen wrote: > > src/slave/slave.cpp, line 3104 > > <https://reviews.apache.org/r/33249/diff/2/?file=937069#file937069line3104> > > > > mesos namespace should been imported?
There are already two TaskStates in slave.cpp, one from the protobuf and one from slave.hpp: - mesos::internal::slave::state::TaskState - mesos::TaskState > On April 21, 2015, 6:03 a.m., Timothy Chen wrote: > > src/tests/slave_tests.cpp, line 280 > > <https://reviews.apache.org/r/33249/diff/2/?file=937070#file937070line280> > > > > You don't need a mock executor right? I've either got to set ExecutorInfo or CommandInfo. It may be a bit more straight forward to set CommandInfo. > On April 21, 2015, 6:03 a.m., Timothy Chen wrote: > > src/tests/slave_tests.cpp, line 329 > > <https://reviews.apache.org/r/33249/diff/2/?file=937070#file937070line329> > > > > What's this for? That was mistakenly added. I based this test off another test and this slipped in. Removed. - Jay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33249/#review80915 ----------------------------------------------------------- On April 21, 2015, 5:14 p.m., Jay Buffington wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33249/ > ----------------------------------------------------------- > > (Updated April 21, 2015, 5:14 p.m.) > > > Review request for mesos, Ben Mahler, Timothy Chen, and Vinod Kone. > > > Bugs: MESOS-2020 > https://issues.apache.org/jira/browse/MESOS-2020 > > > Repository: mesos > > > Description > ------- > > When mesos is unable to launch the containerizer the scheduler should > get a TASK_FAILED with a status message that includes the error the > containerizer encounted when trying to launch. > > Introduces a new TaskStatus: REASON_CONTAINERIZER_LAUNCH_FAILED > > Fixes MESOS-2020 > > > Diffs > ----- > > include/mesos/mesos.proto 3a8e8bf303e0576c212951f6028af77e54d93537 > src/slave/slave.cpp 8ec80ed26f338690e0a1e712065750ab77a724cd > src/tests/slave_tests.cpp b826000e0a4221690f956ea51f49ad4c99d5e188 > > Diff: https://reviews.apache.org/r/33249/diff/ > > > Testing > ------- > > I added test case to slave_test.cpp. I also tried this with Aurora, supplied > a bogus docker image url and saw the "docker pull" failure stderr message in > Aurora's web UI. > > > Thanks, > > Jay Buffington > >
