----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33241/#review81050 -----------------------------------------------------------
High-level comment, this looks good. Ideally, we would be using markdown tables but this isn't consistent in the documentation currently -- nor do I think we properly render/style those styles on the website so that isn't a blocker. - Dave Lester On April 15, 2015, 9:49 p.m., Ricardo Cervera-Navarro wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33241/ > ----------------------------------------------------------- > > (Updated April 15, 2015, 9:49 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-2621 > https://issues.apache.org/jira/browse/MESOS-2621 > > > Repository: mesos > > > Description > ------- > > docs: Add documentation on observability metrics. > > > Diffs > ----- > > docs/home.md 6ab61f85aa7d62e0f19267b886dffb4e0aa826ea > docs/metrics.md PRE-CREATION > > Diff: https://reviews.apache.org/r/33241/diff/ > > > Testing > ------- > > - Previewed in markdown editor. > - Replaced page content using the Element Inspector in Chrome to ensure that > the tables look good. > > > Thanks, > > Ricardo Cervera-Navarro > >
