> On April 21, 2015, 10:03 a.m., Joe Smith wrote:
> > docs/metrics.md, line 227
> > <https://reviews.apache.org/r/33241/diff/2/?file=931101#file931101line227>
> >
> >     hm.. offhand I don't recall what this means, but we should get a 
> > definition here

Unless somebody knows what this is, I'm removing this row.


> On April 21, 2015, 10:03 a.m., Joe Smith wrote:
> > docs/metrics.md, line 345
> > <https://reviews.apache.org/r/33241/diff/2/?file=931101#file931101line345>
> >
> >     "these states match the task state machine"

Added.


> On April 21, 2015, 10:03 a.m., Joe Smith wrote:
> > docs/metrics.md, line 624
> > <https://reviews.apache.org/r/33241/diff/2/?file=931101#file931101line624>
> >
> >     s/registry/registrar, I believe

Added.


> On April 21, 2015, 10:03 a.m., Joe Smith wrote:
> > docs/metrics.md, line 708
> > <https://reviews.apache.org/r/33241/diff/2/?file=931101#file931101line708>
> >
> >     < 60 seconds for a sustained period would track a flapping master

Added.


> On April 21, 2015, 10:03 a.m., Joe Smith wrote:
> > docs/metrics.md, line 714
> > <https://reviews.apache.org/r/33241/diff/2/?file=931101#file931101line714>
> >
> >     tasks in the cluster are disappearing for unknown reasons (either 
> > hardware failure or bugs in mesos or framework)

Added.


On April 21, 2015, 10:03 a.m., Ricardo Cervera-Navarro wrote:
> > looks awesome! some notes

Thanks for your feedback


- Ricardo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33241/#review80995
-----------------------------------------------------------


On April 21, 2015, 3:09 p.m., Ricardo Cervera-Navarro wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33241/
> -----------------------------------------------------------
> 
> (Updated April 21, 2015, 3:09 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2621
>     https://issues.apache.org/jira/browse/MESOS-2621
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> docs: Add documentation on observability metrics.
> 
> 
> Diffs
> -----
> 
>   docs/home.md 6ab61f85aa7d62e0f19267b886dffb4e0aa826ea 
>   docs/metrics.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33241/diff/
> 
> 
> Testing
> -------
> 
> - Previewed in markdown editor.
> - Replaced page content using the Element Inspector in Chrome to ensure that 
> the tables look good.
> 
> 
> Thanks,
> 
> Ricardo Cervera-Navarro
> 
>

Reply via email to