Is this going to be combined with the logic to do the same thing in https://github.com/apache/mesos/blob/master/support/verify_reviews.py which is used for the Jenkins Mesos CI? They are doing about the same thing now in "download a whole set of reviews in order". Be nice to just have one.
On Thu, Oct 8, 2015 at 1:53 PM Artem Harutyunyan <ar...@mesosphere.io> wrote: > Thanks, Adam! Just created > https://issues.apache.org/jira/browse/MESOS-3625. > > Cheers, > Artem. > > On Thu, Oct 8, 2015 at 1:25 PM, Adam Bordelon <a...@mesosphere.io> wrote: > > Hi Artem, thanks for your work on improving the commit process. > > > > I have used the '-g' feature for github PRs in the past, and we should > > continue to support that model, so that new Mesos contributors don't have > > to create new RB accounts and learn a new process just for quick > > documentation changes, etc. > > > > As a side note, now that the Myriad incubator project has migrated to > > Apache git and we can no longer merge PRs directly, we were hoping to > take > > advantage of a tool like apply-reviews to apply our PR patches. It looks > > like apply-reviews.sh only specifies 'mesos' in the GITHUB_URL/API_URL. > > Would apply-reviews.py be just as easy to reuse for another project (i.e. > > Myriad)? > > > > On Thu, Oct 8, 2015 at 11:38 AM, Artem Harutyunyan <ar...@mesosphere.io> > > wrote: > > > >> Folks, > >> > >> The current implementation of apply-review.sh does not allow applying > >> a chain of reviews. It has been a major inconvenience for a lot of us, > >> so I have put together a python script that makes it possible to apply > >> a chain of reviews (the corresponding JIRA is at [0]). The version of > >> the script that uses apply-review.sh internally is posted at [1]. A > >> followup review that removes that dependency is available at [2]. > >> > >> I would like to invite everyone to try it out and tell me what you > >> think about it. Also, as we discussed during the last community sync, > >> we'd like to retire apply-review.sh, so I was wondering whether anyone > >> is still using that script with github. If so, I will go ahead and add > >> support for '-g' in the new script. > >> > >> Cheers, > >> Artem. > >> > >> [0] - https://issues.apache.org/jira/browse/MESOS-3468 > >> [1] - https://reviews.apache.org/r/38705/ > >> [2] - https://reviews.apache.org/r/38883/ > >> >
