>just type "y" and GitHub will redirect to the latest commit in master Cool!
On Tue, Jun 21, 2016 at 10:12 AM, Erik Weathers <[email protected]> wrote: > @Kevin: > > FYI, it's best practice to use a commit SHA in GitHub links so that future > readers are seeing the content you intended. > > i.e., instead of: > > - > > https://github.com/NVIDIA/nvidia-docker/blob/master/tools/src/nvidia/volumes.go#L109 > > It's best to do: > > - > > https://github.com/NVIDIA/nvidia-docker/blob/101b436c89c3a74e9a3025a104587b6612d903d8/tools/src/nvidia/volumes.go#L109 > > > And (awesomely!) GitHub makes it trivial to do this! [1] > > - when you're looking at a file (such as the original link you > pasted), just type "y" and GitHub will redirect to the latest commit in > master: > > - Erik > > [1] https://help.github.com/articles/getting-permanent-links-to-files/ > > On Mon, Jun 20, 2016 at 6:59 PM, Kevin Klues <[email protected]> wrote: > >> For now we've decided to actually remove the hard dependence on libelf >> for the 1.0 release and spend a bit more time thinking about the right >> way to pull it in. >> >> Jean, to answer your question though -- someone would still need to >> consolidate these libraries, even if it wasn't left to Mesos to do so. >> These libraries are spread across the file system, and need to be >> pulled into a single place for easy injection. The full list of >> binaries / libraries are here: >> >> >> https://github.com/NVIDIA/nvidia-docker/blob/master/tools/src/nvidia/volumes.go#L109 >> >> We could put this burden on the operator and trust he gets it right, >> or we could have Mesos programmatically do it itself. We considered >> just leveraging the nvidia-docker-plugin itself (instead of >> duplicating its functionality into mesos), but ultimately decided it >> was better not to introduce an external dependency on it (since it is >> a separate running excutable, rather than a simple library, like >> libelf). >> >> On Mon, Jun 20, 2016 at 5:12 PM, Jean Christophe “JC” Martin >> <[email protected]> wrote: >> > As an operator not using GPUs, I feel that the burden seems misplaced, >> and disproportionate. >> > I assume that the operator of a GPU cluster knows the location of the >> libraries based on their OS, and could potentially provide this information >> at the time of creating the containers. I am not sure to see why this >> something that mesos is required to do (consolidating the libraries in the >> volume, versus being a configuration/external information). >> > >> > Thanks, >> > >> > JC >> > >> >> On Jun 20, 2016, at 2:30 PM, Kevin Klues <[email protected]> wrote: >> >> >> >> Sorry, the ticket just links to the nvidia-docker project without much >> >> further explanation. The information at the link below should make it >> >> a bit more clear: >> >> >> >> https://github.com/NVIDIA/nvidia-docker/wiki/NVIDIA-driver. >> >> >> >> The crux of the issue is that we need to be able consolidate all of >> >> the Nvidia binaries/libraries into a single volume that we inject into >> >> a docker container. We use libelf is used to get the canonical names >> >> of all the Nvidia libraries (i.e. SONAME in their dynamic sections) as >> >> well as lookup what external dependences they have (i.e. NEEDED in >> >> their dynamic sections) in order to build this volume. >> >> >> >> NOTE: None of this volume support is actually in Mesos yet -- we just >> >> added the libelf dependence in anticipation of it. >> >> >> >> >> >> >> >> >> >> On Mon, Jun 20, 2016 at 12:59 PM, Yan Xu <[email protected]> wrote: >> >>> It's not immediately clear form the ticket why the change from >> optional >> >>> dependency to required dependency though? Could you summarize? >> >>> >> >>> >> >>> On Sun, Jun 19, 2016 at 12:33 PM, Kevin Klues <[email protected]> >> wrote: >> >>>> >> >>>> Thanks Zhitao, >> >>>> >> >>>> I just pushed out a review for upgrades.md and added you as a >> reviewer. >> >>>> >> >>>> The new dependence was added in the JIRA that haosdent linked, but >> the >> >>>> actual reason for adding the dependence is more related to: >> >>>> https://issues.apache.org/jira/browse/MESOS-5401 >> >>>> >> >>>> On Sun, Jun 19, 2016 at 9:34 AM, haosdent <[email protected]> >> wrote: >> >>>>> The related issue is Change build to always enable Nvidia GPU >> support >> >>>>> for >> >>>>> Linux >> >>>>> Last time my local build break before Kevin send out the email, and >> then >> >>>>> find this change. >> >>>>> >> >>>>> On Mon, Jun 20, 2016 at 12:11 AM, Zhitao Li <[email protected]> >> >>>>> wrote: >> >>>>>> >> >>>>>> Hi Kevin, >> >>>>>> >> >>>>>> Thanks for letting us know. It seems like this is not called out in >> >>>>>> upgrades.md, so can you please document this additional dependency >> >>>>>> there? >> >>>>>> >> >>>>>> Also, can you include the link to the JIRA or patch requiring this >> >>>>>> dependency so we can have some contexts? >> >>>>>> >> >>>>>> Thanks! >> >>>>>> >> >>>>>> On Sat, Jun 18, 2016 at 10:25 AM, Kevin Klues <[email protected]> >> >>>>>> wrote: >> >>>>>> >> >>>>>>> Hello all, >> >>>>>>> >> >>>>>>> Just an FYI that the newest libmesos now has an external >> dependence >> >>>>>>> on >> >>>>>>> libelf on Linux. This dependence can be installed via the >> following >> >>>>>>> packages: >> >>>>>>> >> >>>>>>> CentOS 6/7: yum install elfutils-libelf.x86_64 >> >>>>>>> Ubuntu14.04: apt-get install libelf1 >> >>>>>>> >> >>>>>>> Alternatively you can install from source: >> >>>>>>> https://directory.fsf.org/wiki/Libelf >> >>>>>>> >> >>>>>>> For developers, you will also need to install the libelf headers >> in >> >>>>>>> order to build master. This dependency can be installed via: >> >>>>>>> >> >>>>>>> CentOS: elfutils-libelf-devel.x86_64 >> >>>>>>> Ubuntu: libelf-dev >> >>>>>>> >> >>>>>>> Alternatively, you can install from source: >> >>>>>>> https://directory.fsf.org/wiki/Libelf >> >>>>>>> >> >>>>>>> The getting started guide and the support/docker_build.sh scripts >> >>>>>>> have >> >>>>>>> been updated appropriately, but you may need to update your local >> >>>>>>> environment if you don't yet have these packages installed. >> >>>>>>> >> >>>>>>> -- >> >>>>>>> ~Kevin >> >>>>>>> >> >>>>>> >> >>>>>> >> >>>>>> >> >>>>>> -- >> >>>>>> Cheers, >> >>>>>> >> >>>>>> Zhitao Li >> >>>>> >> >>>>> >> >>>>> >> >>>>> >> >>>>> -- >> >>>>> Best Regards, >> >>>>> Haosdent Huang >> >>>> >> >>>> >> >>>> >> >>>> -- >> >>>> ~Kevin >> >>> >> >>> >> >> >> >> >> >> >> >> -- >> >> ~Kevin >> > >> >> >> >> -- >> ~Kevin >> > > -- Best Regards, Haosdent Huang
