Tomek I think that patch also needs to address accepting strings for floating point fields: float, double.
IMO, to avoid confusion, we want to get as close as possible to the proto3 specified mapping, which allows string inputs for all types of numeric fields: https://developers.google.com/protocol-buffers/docs/proto3#json This means that on the output side, we need to figure out how to transition to using strings for 64 bit integers without breaking our existing endpoint consumers. On Fri, Mar 24, 2017 at 12:31 PM, Anand Mazumdar <an...@apache.org> wrote: > Hi Tomek, > > Looks like we dropped the ball on MESOS-5995 > (https://issues.apache.org/jira/browse/MESOS-5995). I assigned myself > as the shepherd and would take a look next week. > > -anand > > On Thu, Mar 23, 2017 at 2:09 AM, Tomek Janiszewski <jani...@gmail.com> > wrote: > > I have a similar problem with protobuf and json. In my case numbers were > > incorrectly unmarshaled. Here is an issue > > https://issues.apache.org/jira/browse/MESOS-970 and review > > https://reviews.apache.org/r/50851/ > > > > czw., 23.03.2017, 09:54 użytkownik Olivier Sallou < > olivier.sal...@irisa.fr> > > napisał: > > > >> Hi, > >> > >> when transforming a protobug message to json with MessageToJson, the > >> json is not compatible with the json format expected by Mesos master. > >> > >> For example, for volumes it generates > >> > >> > >> volumes: [ > >> > >> {'hostPath': '....', > >> > >> 'containerPath': '...', > >> > >> ... > >> > >> } > >> > >> ] > >> > >> > >> but HTTP API expects "source" and "container_path" > >> > >> is it an expected behavior ? This prevents from "creating" a task in > >> protobuf format and sending it to HTTP API with a protobug to json > >> conversion. > >> > >> Thanks > >> > >> Olivier > >> > >> -- > >> Olivier Sallou > >> IRISA / University of Rennes 1 > >> Campus de Beaulieu, 35000 RENNES - FRANCE > >> Tel: 02.99.84.71.95 > >> > >> gpg key id: 4096R/326D8438 (keyring.debian.org) > >> Key fingerprint = 5FB4 6F83 D3B9 5204 6335 D26D 78DC 68DB 326D 8438 > >> > >> >
