> On juni 5, 2015, 1:40 p.m., Tomasz Guzialek wrote: > > pom.xml, line 67 > > <https://reviews.apache.org/r/35123/diff/2/?file=979940#file979940line67> > > > > Isn't HDFS a better name? Name Hadoop brings also the processing > > framework to the game.
I was thinking of doing it this way so that other hadoop-client related utilities could be put in here. And then it also makes sense to let e.g. the hbase module depend on this module and have it's dependencies managed from here. - Kasper ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35123/#review86793 ----------------------------------------------------------- On juni 5, 2015, 1:30 p.m., Kasper Sørensen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35123/ > ----------------------------------------------------------- > > (Updated juni 5, 2015, 1:30 p.m.) > > > Review request for MetaModel. > > > Bugs: METAMODEL-148 > https://issues.apache.org/jira/browse/METAMODEL-148 > > > Repository: metamodel > > > Description > ------- > > This more or less fixes METAMODEL-148. > > Items I am not sure about: > > * I am not sure if we can implement the isReadOnly() method in any sensible > way? > * I wanted to have as little client-side configuration as possible, so I > create the hadoop Configuration on-the-fly. Maybe it would be good also with > an option to load it from a hadoop conf XML file? > * I updated also hbase to the latest version, but that created a lot of > deprecation warnings, so I should probably rather just leave it alone :-P > > > Diffs > ----- > > core/src/main/java/org/apache/metamodel/util/Func.java 684411f > core/src/main/java/org/apache/metamodel/util/UncheckedFunc.java > PRE-CREATION > hadoop/.gitignore PRE-CREATION > hadoop/pom.xml PRE-CREATION > hadoop/src/main/java/org/apache/metamodel/util/HdfsResource.java > PRE-CREATION > hadoop/src/test/java/org/apache/metamodel/util/HdfsResourceTest.java > PRE-CREATION > hbase/pom.xml b3ded40 > hbase/src/main/java/org/apache/metamodel/hbase/HBaseDataContext.java > a501790 > pom.xml 5cb93f3 > > Diff: https://reviews.apache.org/r/35123/diff/ > > > Testing > ------- > > Only local testing. And monkey tested it with my own HDFS setup. > Probably needs a formal integration test. > > > Thanks, > > Kasper Sørensen > >
