Github user LosD commented on the pull request:
https://github.com/apache/metamodel/pull/62#issuecomment-150558274
Code looks good, but it's not a particular good change to me: It is totally
fine to add new functions (like approximate_count() or something like that)
that are not base SQL, but breaking SQL syntax seems a bit... Nasty to me.
Relational database vendors do all kinds of horrible things to SQL, but I
don't think even they would go that far.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
