Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/62#issuecomment-150560414
The concern is that actually it's a flag you can set independently of which
function it applies to. I have only myself used it wrt. COUNT function, but you
could also query an approximate AVG function or something like that. This means
that "just" adding approximate_count would not work - and it would not support
people plugging in new functions themselves.
I guess we could introduce it as a first-class keyword like DISTINCT, then
it would be ```SELECT APPROXIMATE COUNT(*) FROM table``` instead ... Not sure I
like that better, but it would work I guess.
A word of comfort: People that expect MetaModel to use "standard SQL" would
probably never set this flag because it is not part of any standard at all. So
they would never encounter the tilde symbol anywhere :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
