GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/96
(draft) METAMODEL-244
I wanted to give a shot at fixing METAMODEL-244 so here goes.
I made available a strategy interface for column naming, which I
implemented in a few different ways, and created a default delegating strategy
as well. It's implemented in the 'fixedwidth' module only for now.
I also managed to fix something which I've encountered a few times before,
but newer got around to report as an issue: The fact that it is annoying that
you sometimes get duplicated column names for CSV files and such. That should
rarely be allowed, so I implemented a strategy for renaming those duplicated
column names automatically.
I'd like a review if anyone is willing. If you agree that the approach
taken is good I will happily also apply it in the excel and csv module. It
would be quite easy I think actually.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kaspersorensen/metamodel METAMODEL-244
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metamodel/pull/96.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #96
----
commit 3d0666cabce5e6df40ec341bb1d21b74343d1e3f
Author: kaspersorensen <[email protected]>
Date: 2016-04-22T21:54:22Z
METAMODEL-244: Made ColumnNamingStrategy available to fixedwidth module
commit 0da8f1a1cb9fa8bfe87eb73f38df047d111e196d
Author: kaspersorensen <[email protected]>
Date: 2016-04-22T22:50:06Z
METAMODEL-244: Refactored fixedwidth module a bit and added strategies
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
