Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/96#discussion_r60834460
--- Diff:
core/src/main/java/org/apache/metamodel/schema/builder/ColumnNamingStrategy.java
---
@@ -0,0 +1,37 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.metamodel.schema.builder;
+
+/**
+ * A strategy that defines how columns are logically named. Such
strategies are
+ * mostly used when a particular datastore is not itself intrinsically
+ * specifying the column name.
+ */
+public interface ColumnNamingStrategy {
+
+ /**
+ * Provides the name to apply for a given column.
+ *
+ * @param ctx
+ * the context of the column naming taking place. This
contains
+ * column index, intrinsic name etc. if available.
+ * @return the name to provide to the column.
+ */
+ public String getNextColumnName(ColumnNamingContext ctx);
--- End diff --
I'm wondering if this method should reside here or in some object that is
scoped just for the individual table. Because right now the interface seems to
be global fir many tables but implementations typically need state which is
scoped only for the duration of naming a single table.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
