Github user LosD commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/103#discussion_r64030560
  
    --- Diff: 
fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/FixedWidthConfiguration.java
 ---
    @@ -54,45 +56,49 @@ public FixedWidthConfiguration(int fixedValueWidth) {
        }
     
        public FixedWidthConfiguration(int[] valueWidth) {
    -           this(DEFAULT_COLUMN_NAME_LINE, FileHelper.DEFAULT_ENCODING, 
valueWidth,
    -                           false);
    +           this(DEFAULT_COLUMN_NAME_LINE, FileHelper.DEFAULT_ENCODING, 
valueWidth, false, false, true);
        }
     
         public FixedWidthConfiguration(int columnNameLineNumber, String 
encoding, int fixedValueWidth) {
    -        this(columnNameLineNumber, encoding, fixedValueWidth, false);
    +        this(columnNameLineNumber, encoding, fixedValueWidth, false, 
false, true);
         }
     
         public FixedWidthConfiguration(int columnNameLineNumber, String 
encoding, int fixedValueWidth,
    -            boolean failOnInconsistentLineWidth) {
    +            boolean failOnInconsistentLineWidth, boolean headerPresent, 
boolean eolPresent) {
             this.encoding = encoding;
             this.fixedValueWidth = fixedValueWidth;
             this.columnNameLineNumber = columnNameLineNumber;
             this.failOnInconsistentLineWidth = failOnInconsistentLineWidth;
    +           this.headerPresent = headerPresent;
    +           this.eolPresent = eolPresent;
             this.columnNamingStrategy = null;
             this.valueWidths = new int[0];
         }
     
         public FixedWidthConfiguration(int columnNameLineNumber, String 
encoding,
    -            int[] valueWidths, boolean failOnInconsistentLineWidth) {
    -        this(columnNameLineNumber, null, encoding, valueWidths, 
failOnInconsistentLineWidth);
    +            int[] valueWidths, boolean failOnInconsistentLineWidth, 
boolean headerPresent, boolean eolPresent) {
    +        this(columnNameLineNumber, null, encoding, valueWidths, 
failOnInconsistentLineWidth, headerPresent,
    +                           eolPresent);
         }
         
         public FixedWidthConfiguration(int columnNameLineNumber, 
ColumnNamingStrategy columnNamingStrategy, String encoding,
    -            int[] valueWidths, boolean failOnInconsistentLineWidth) {
    +            int[] valueWidths, boolean failOnInconsistentLineWidth, 
boolean headerPresent, boolean eolPresent) {
             this.encoding = encoding;
             this.fixedValueWidth = -1;
             this.columnNameLineNumber = columnNameLineNumber;
             this.failOnInconsistentLineWidth = failOnInconsistentLineWidth;
    +           this.headerPresent = headerPresent;
    +           this.eolPresent = eolPresent;
    --- End diff --
    
    And here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to