Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/103#discussion_r64159744
--- Diff:
fixedwidth/src/test/java/org/apache/metamodel/fixedwidth/FixedWidthConfigurationTest.java
---
@@ -27,18 +27,18 @@
public void testToString() throws Exception {
assertEquals(
"FixedWidthConfiguration[encoding=UTF8,
fixedValueWidth=10, valueWidths=[], columnNameLineNumber=1,
failOnInconsistentLineWidth=true]",
- new FixedWidthConfiguration(1, "UTF8", 10,
true).toString());
+ new FixedWidthConfiguration(1, "UTF8", 10,
true, false, true).toString());
}
public void testEquals() throws Exception {
FixedWidthConfiguration conf1 = new FixedWidthConfiguration(1,
"UTF8",
- 10, true);
+ 10, true, false, true);
--- End diff --
Please make sure there are overloaded constructors available for the old
constructor signature. Then you also wont have to change this existing test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
