Github user jhorcicka commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/103#discussion_r67468607
--- Diff:
fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/FixedWidthConfiguration.java
---
@@ -33,66 +33,74 @@
/**
* Configuration of metadata about a fixed width values datacontext.
*/
-public final class FixedWidthConfiguration extends BaseObject implements
- Serializable {
+public final class FixedWidthConfiguration extends BaseObject implements
Serializable {
- private static final long serialVersionUID = 1L;
+ private static final long serialVersionUID = 1L;
- public static final int NO_COLUMN_NAME_LINE = 0;
- public static final int DEFAULT_COLUMN_NAME_LINE = 1;
+ public static final int NO_COLUMN_NAME_LINE = 0;
+ public static final int DEFAULT_COLUMN_NAME_LINE = 1;
- private final String encoding;
- private final int fixedValueWidth;
- private final int[] valueWidths;
- private final int columnNameLineNumber;
- private final boolean failOnInconsistentLineWidth;
- private final ColumnNamingStrategy columnNamingStrategy;
+ private final String encoding;
+ private final int fixedValueWidth;
+ private final int[] valueWidths;
+ private final int columnNameLineNumber;
+ private final boolean failOnInconsistentLineWidth;
+ private final boolean headerPresent;
--- End diff --
I would go with ```skipEbcdicHeader``` then. I also feel that EBCDIC is
something special in the context of fixed-width but let's solve this within a
new issue as a refactoring part. There already are other projects waiting for
this to be merged and this kind of communication takes a lot of time.
So, let's change the name to ```skipEbcdicHeader```, focus on other aspects
of this PR and then merge it. Then we can start a new discussion about
separation of EbcdicConfiguration. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
